Open
Conversation
…r-proposal-lifecycle
… plus other suggestions
…r-proposal-lifecycle
Base automatically changed from
solana/4-settler-signatures
to
solana/settler
January 21, 2026 15:19
PedroAraoz
requested changes
Jan 21, 2026
Member
PedroAraoz
left a comment
There was a problem hiding this comment.
General comments
- If we are going to always do
&[EntityType::Solver as u8 + 1]when using the controller from the settler, I would just change the controller so the enum starts at 0. - Follow the testing convention we use, you can use the EVM Settler as reference
- Extract repeated code into functions
- Always use helper functions, for example when creating the intent it is sometimes done createTestIntent but not always
Helpers.ts
Leaving this here because GH does not allow commenting on files not changed by the PR
- I would split it into multiple files
- I would split createTestIntent into one function that creates the data (like we use in the backend repo) and maybe another that sends the ix and returns the hash
Member
Author
|
Feedback about your earlier message @PedroAraoz:
Granted. Changed
Modified tests to follow that convention better, still unsure if they are properly formatted
Did this with everything I could, let me know if you see anything I missed
Tried to fix that as well, again let me know if I missed anything
I split this into several files now, grouping functionality together
Makes sense, done. |
Member
Author
|
NOTE: The |
PedroAraoz
reviewed
Jan 28, 2026
PedroAraoz
reviewed
Feb 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes Settler unit test pattern to use
context()as requested in previous PRs (comes from #50).